https://bugzilla.wikimedia.org/show_bug.cgi?id=67343
Bug ID: 67343
Summary: Scribunto fetchLanguageName tests fail if CLDR is not
installed
Product: MediaWiki extensions
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Scribunto
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: tstarl...@wikimedia.org
CC: bjor...@wikimedia.org, tstarl...@wikimedia.org,
vasi...@gmail.com
Web browser: ---
Mobile Platform: ---
6 Scribunto PHPUnit tests fail if CLDR is not installed. These tests should be
skipped instead.
On the Lua side, testframework.getTestProvider() gives name, func, args and
expect parameters. A "skip" parameter could be added which skips tests in
Scribunto_LuaEngineTestBase::testLua() if a given "skip tag" string is
registered by the PHP layer.
builder@hhvm-syd:/mnt/build/src/mediawiki/core$ hhvm -c ~/etc/server.hdf
tests/phpunit/phpunit.php
../extensions/Scribunto/tests/engines/LuaCommon/LanguageLibraryTest.php
PHPUnit 4.1.3 by Sebastian Bergmann.
Configuration read from /mnt/build/src/mediawiki/core/tests/phpunit/suite.xml
S..FF...F........................................S..FF...F....... 65 / 98 (
66%)
.................................
Time: 15.13 seconds, Memory: 52.67Mb
There were 6 failures:
1) LuaSandbox: LanguageLibraryTests[3]: fetchLanguageName (en,ru)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
{
- "английский",
+ "English",
}
/mnt/build/src/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:235
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:133
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:42
2) LuaSandbox: LanguageLibraryTests[4]: fetchLanguageName (ru,en)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
{
- "Russian",
+ "русский",
}
/mnt/build/src/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:235
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:133
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:42
3) LuaSandbox: LanguageLibraryTests[8]: fetchLanguageNames (de)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
{
{
- ["en"] = "Englisch",
- ["ru"] = "Russisch",
+ ["en"] = "English",
+ ["ru"] = "русский",
},
}
/mnt/build/src/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:235
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:133
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:42
4) LuaStandalone: LanguageLibraryTests[3]: fetchLanguageName (en,ru)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
{
- "английский",
+ "English",
}
/mnt/build/src/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:235
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:133
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:42
5) LuaStandalone: LanguageLibraryTests[4]: fetchLanguageName (ru,en)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
{
- "Russian",
+ "русский",
}
/mnt/build/src/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:235
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:133
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:42
6) LuaStandalone: LanguageLibraryTests[8]: fetchLanguageNames (de)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
{
{
- ["en"] = "Englisch",
- ["ru"] = "Russisch",
+ ["en"] = "English",
+ ["ru"] = "русский",
},
}
/mnt/build/src/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:235
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:133
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:42
--
There were 2 skipped tests:
1) LuaSandbox: Scribunto_LuaLanguageLibraryTests::testFormatDateTTLs
Language::sprintfDate does not set a TTL
/mnt/build/src/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LanguageLibraryTest.php:25
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:133
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:42
2) LuaStandalone: Scribunto_LuaLanguageLibraryTests::testFormatDateTTLs
Language::sprintfDate does not set a TTL
/mnt/build/src/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LanguageLibraryTest.php:25
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:133
/mnt/build/src/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:42
FAILURES!
Tests: 98, Assertions: 96, Failures: 6, Skipped: 2.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
