https://bugzilla.wikimedia.org/show_bug.cgi?id=45219
Matthew Flaschen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Assignee|[email protected] |[email protected]. | |org --- Comment #7 from Matthew Flaschen <[email protected]> --- Sam, I think adding a new hook in SpecialRedirectToSpecial (as you suggested on IRC) should be fine. The alternative would be to add it to RedirectSpecialPage (the parent class), but SpecialRedirectToSpecial is the more granular approach (it can be RedirectSpecialArticle, SpecialRedirectToSpecial, both, or neither). The starting array (to be modified by the hook) should be the one passed to the SpecialRedirectToSpecial constructor ($allowedRedirectParams). Also, it should probably pass $this to the hook (as the first parameter), so the listener can optionally vary its behavior depending on the special page (e.g. $this->mName). It should be safe for GuidedTour, since there is already the $isUserJsAllowed check in GuidedTourHooks.php, but this should be tested. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
