https://bugzilla.wikimedia.org/show_bug.cgi?id=67984
Bug ID: 67984
Summary: EditPage member variable visibility changes broke
compatibility for extensions
Product: MediaWiki
Version: 1.24-git
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: minor
Priority: Unprioritized
Component: General/Unknown
Assignee: [email protected]
Reporter: [email protected]
Web browser: ---
Mobile Platform: ---
The following change made some member variables of the EditPage class
protected:
https://gerrit.wikimedia.org/r/#/c/133484/
The change seems to have been intended simply as a cleanup, but it broke
compatibility with at least one extension, Semantic Forms. (See bug:
https://bugzilla.wikimedia.org/show_bug.cgi?id=67522 ) I don't know whether or
not any other extensions are affected.
Extension compatibility might not be such a high priority, but given the nature
of the commit (just a cleanup), I file this in case making EditPage::$mTokenOk
public again is agreeable. (I also saw that some other visibility changes from
the above commit, to another class, were adjusted when they caused another,
more serious problem: https://bugzilla.wikimedia.org/show_bug.cgi?id=65665 )
If you want to keep EditPage::$mTokenOk private, an alternative proposal would
be to add a method to return the $mTokenOk status. That would still require
changing any code that now relies on reading $mTokenOk, but it would make for
the cleanest change.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
