https://bugzilla.wikimedia.org/show_bug.cgi?id=67997
Brad Jorsch <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected], | |[email protected] --- Comment #4 from Brad Jorsch <[email protected]> --- (In reply to Pavel (pastakhov) from comment #0) > Firstly, the function CacheTime::updateCacheExpiry() does not affect the > browser cache. That's because CacheTime::updateCacheExpiry() isn't supposed to be dealing with the browser cache. It's dealing with the lifetime of the CacheTime object in the parser cache. Whether If-Modified-Since should be ignored on a parser cache miss, or if we should store the parser TTL alongside page_touched and have the If-Modified-Since check use the max of page_touched or time() - TTL, is debatable. I'd rather hear from someone who knows more about caching than I do, like Ori or Aaron. > I tried to get around this using $wgOut->enableClientCache(false); > And when Article::view: doing uncached parse is sent > OutputPage::sendCacheControl: no caching ** > But when ParserOutput cache found is sent OutputPage::sendCacheControl: > private caching; Mon, 14 Jul 2014 13:42:49 GMT ** instead of 'no caching '. $wgOut is the OutputPage object. If you're calling $wgOut->enableClientCache(false) as part of the parse, which it sounds like is the case, your code isn't being called when a cached ParserOutput is used so it never gets a chance to affect the OutputPage. This would be expected behavior. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
