https://bugzilla.wikimedia.org/show_bug.cgi?id=68021
Bug ID: 68021
Summary: JS cleanup: use data-api-target (in template) instead
of seeking out specific nodes in JS
Product: MediaWiki extensions
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Flow
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected], [email protected],
[email protected]
Web browser: ---
Mobile Platform: ---
In order to wrap up frontend changes sonner rather than later, some corners
were cut. The plan was to avoid finding specific nodes in JS code, but rather
have selectors etc in the templates.
Try searching for .closest( 'form' ) in flow-board.js, for example ;)
Here's an incomplete list of stuff that definitely needs fixing. Please help
complete this list & fix the code ;)
* Error handling: FlowBoardComponent.UI.events.interactiveHandlers.apiRequest
has generic error handling, but always attached the error message to
$this.closest( 'form' ) - even though errors can occur without relevant forms
(e.g. FlowBoardComponent.UI.events.apiHandlers.board, which has to manually
attach the errors because the generic error handling assumes form...)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
