https://bugzilla.wikimedia.org/show_bug.cgi?id=68064

            Bug ID: 68064
           Summary: Can't dismiss banners on mobile due to $.toJSON not
                    being defined
           Product: MediaWiki extensions
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: Unprioritized
         Component: CentralNotice
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected], [email protected]
       Web browser: ---
   Mobile Platform: ---

On my local machine, the hideBanner() function doesn't work in mobile because
it throws the following JS error:

$.toJSON is not a function

in BannerController:
$.cookie(
    'centralnotice_hide_' + mw.centralNotice.data.category,
    $.toJSON( cookieVal ),
    { expires: d, path: '/' }
);

I'm not sure why $.toJSON isn't working on mobile, but it's deprecated anyway
and is going to be removed from core in MW 1.25. You should use JSON.stringify
instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to