https://bugzilla.wikimedia.org/show_bug.cgi?id=13353

Chad H. <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|need-review                 |
                 CC|                            |[email protected]
            Version|1.12.x                      |1.17-svn
            Summary|MediaWiki 1.12.0rc1 does    |Diff3 version checks are
                   |not find diff-util on       |too strict, doesn't detect
                   |FreeBSD 6.2 with safemode   |working diff3
           Severity|major                       |normal

--- Comment #4 from Chad H. <[email protected]> 2010-05-20 22:55:47 UTC 
---
A bit of both (two issues are identified here).

The main issue is exec() and friends in safe mode. As pointed out in comment
#2, it's patently broken in these setups. If there are enhancements we can make
to help safe mode users that don't create issues for the rest of us then they
should be incorporated into wfShellExec() rather than unconditionally failing
like we currently do. However, that's outside the scope of this bug (on a
tangent, anything not using wfShellExec() should be) and is a WONTFIX as far as
I'm concerned.

The second issue here is that when we're looking for diff3, we're expecting
some rather specific output from --version (which is still true with the new
installer merged to trunk). The original report obviously has a working diff3,
we just don't allow it because its version output isn't matching. This should
certainly be fixed and I'm repurposing the bug to concentrate on that.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to