https://bugzilla.wikimedia.org/show_bug.cgi?id=68073

Krinkle <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
            Summary|VisualEditor: [Regression   |VisualEditor: [Regression
                   |pre-wmf14] In new save      |pre-wmf14] Save button in
                   |dialog, the Save button     |save dialog remains active
                   |remains active while the    |while save is in progress
                   |save is in progress and     |and throws "Uncaught
                   |clicking on that throws     |TypeError: Cannot read
                   |error: Uncaught TypeError:  |property '$saveOptions' of
                   |Cannot read property        |null"
                   |'$saveOptions' of null      |

--- Comment #5 from Krinkle <[email protected]> ---
I can reproduce both the UI as well as the logic problem.

Both the "Review your changes" and the "Save page" buttons in the save dialog
remain clickable.

Their apparent state looks clickable, their response to clicking is appeared
pressed, and the result is the event handler firing internally.

The exception usually doesn't happen until after the first save attempt has
finished and the view goes back to "read" mode, but it does throw:

ve.init.mw.ViewPageTarget.prototype.onSave = function ( ..  ) {
    if ( !this.pageExists || this.restoring ) {
        ..
    } else {
        if ( mw.page.watch && mw.page.watch.updateWatchLink ) {
            watchChecked = this.saveDialog.$saveOptions
.. ^

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to