https://bugzilla.wikimedia.org/show_bug.cgi?id=23641

--- Comment #5 from Happy-melon <[email protected]> 2010-05-25 11:14:34 UTC 
---
-        $this->doEdit( $text, $summary, $flags );
+        $this->doEdit( $text, $summary, $flags, $false, null, $watchthis, true
);

"$false"??  Please test your code before submitting.  

+     * @param $watchthis Unwatch the page if null, otherwise watch it; ignored
if $alterWatchlist is null
+     * @param $alterWatchlist If null, watchlist will be left alone; otherwise
page will be watched or unwatched,
+     *             depending upon value of $watchthis

It would be nicer to implement this as one parameter $watch, where the page is
watched if true, unwatched if false, and left unchanged if null.  Right now
there are no hooks in SVN making use of the existing $watchthis parameter, so
there's no harm in slightly tweaking its implementation.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to