https://bugzilla.wikimedia.org/show_bug.cgi?id=5645
--- Comment #25 from George Orwell III <george.orwell....@outlook.com> ---
(In reply to This, that and the other (TTO) from comment #24)
> It may seem that simple to you, but it needs to be possible
> for this type of configuration to be altered *without* editing
> core JavaScript files, for a couple of reasons:
> 1. These files are overwritten whenever the MW software is upgraded
So adding the filter line set to just let the button appear in only ns-talk
spaces in this build means that setting could somehow be lost in the next build
without the file being further 'touched'? That seems odd.
> 2. On a big cluster like WMF's, all wikis run the same,
> automatically updated code base, thereby making
> per-wiki hacks impossible
So you're assuming there would be a desire somewhere in either real-world or
wiki-world usage to negate the button's generation in spite of the all
namespaces in question being talk namespaces and only talk namespaces?
> I still favour
> option 2 (currently implemented in the proposed patch) as it appears this
> would be particularly useful for VisualEditor and other such systems, as
> well as MediaWiki core and WikiEditor.
I like option 2 as well - just wish it was not still up for debate not to
mention beyond the original scope of the originally reported issue ('Bug 5645 -
Hide signature button from edit toolbar in main namespace'). Even when this
somehow later morphed into the inability of ext.wikiEditor.toolbar.hideSig.js
to function as first hoped, its still a solution in search of a problem that to
date has only presented itself in theory.
And how would adding the filter parameter set for only ns-talk pages today
affect your content-detection based proposal implemented tomorrow or next week
or whenever? Does the designed filter in the extension then become moot if the
content-based solution is in place? Would it hamper testing or enhance it in
moving forward?
There seems to be little consistency here other than the search for
'perfection' becoming the enemy of the 'good'.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
