https://bugzilla.wikimedia.org/show_bug.cgi?id=68712

Kunal Mehta (Legoktm) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|PATCH_TO_REVIEW             |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Kunal Mehta (Legoktm) <[email protected]> ---
I discussed this with Roan on IRC today. He pointed out that if we use
addModuleStyles/addModuleScripts, the modules go through
OutputPage::makeResourceLoaderLink, resulting in independent <link>/<script>
tags as we want, while addModules just adds them to a mw.loader.load array.
Additionally, OutputPage already special cases the 'user' group versioning, so
that's taken care of.

Since we no longer need the hook, I've reverted it, and updated GlobalCssJs as
well. Yay!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to