https://bugzilla.wikimedia.org/show_bug.cgi?id=24041
--- Comment #9 from Helder <[email protected]> --- (In reply to George Orwell III from comment #7) Copying from https://gerrit.wikimedia.org/r/#/c/141296/ : I was worried that WikiEditor customizations like [ https://en.wiktionary.org/wiki/MediaWiki:Gadget-DeveloperEditorTweaks.js and https://pt.wikibooks.org/wiki/User:Helder.wiki/Tools/CodingToolbar.js ] will stop working in every wiki were CodeEditor is not used (because in this case there will be no WikiEditor on JS pages). Fortunately, I just checked and it won't break as long as the code uses "mw.loader.using( 'ext.wikiEditor.toolbar', ... )" to add WikiEditor before interacting with it. I think the same applies to the ProofreadPage extension. It seems the extension can force the toolbar to be loaded on any page it wants by just loading the appropriate RL module. However I think it makes sense to allow extensions to configure the list of content models against which $editPage->contentModel is tested. That is, something like if ( in_array( $editPage->contentModel, array( CONTENT_MODEL_WIKITEXT, ... ) ) ) { instead of if ( $editPage->contentModel !== CONTENT_MODEL_WIKITEXT ) { where "..." could be set by other extensions which rely on WikiEditor. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
