https://bugzilla.wikimedia.org/show_bug.cgi?id=68332
--- Comment #9 from Marcin Cieślak <[email protected]> --- I have added two bugs and reopened this bug because I have a need to document all issues related to automatic skin discovery and fallback. This is IMHO the right bug to do it (no need for an extra tracking bug or something). If current fallback would be working, we would not have bug 70222. Bug 70114 is related to the skin autodiscovery/fallback issues, but the problem here lies most probably in the packaging of that particular Vagrant instance; therefore I have moved it to the Vagrant components but added as a dependency here. Here is my rationale for what I believe would constitute a new better fallback/autodiscovery mechanism: 1) We have lost some crude form of skin autodiscovery, namely there was a list of skins that was hardcoded and they were tried one by one. 2) The only thing left is now $wgDefaultSkin settings, that in a typical git checkout points to a non-existing skin. We have some kind of workaround in the WebInstaller to switch to Vector if present. 3) I believe we need now a new way of autoconfiguring skins, which should be something more or less as follows: (A) Define set of paths ($IP/w/skins/ $ip/w/skins-ext, whatever, maybe also php_includes) where we look for skin components. (B) Try to dynamically include some conventional names if files exist (SkinName/SkinName.php or something like that). (C) The list of $wgValidSkinNames[] gets populated either by enumeration code outside of the skin (my favourite now) or by the skin initialization code themselves. (D) This way we have a potential list of candidate skins for the default. (E) If Vector is not present, one of the present skins should be the new default one. (F) Even if Vector is present, we might think of some other, pre-installation mechanisms to say, *This is my default skin* (G) All of above should happen somewhere around includes/Setup.php and not in the installer (that's why I don't think "Installer" is the right component for the bug 70222). (H) The WebInstaller picks the best default for itself. (I) The installer offers skins to the end-user (this is bug 68331). (I) Installer adds then appropriate require_once() code to the LocalSettings.php to all skins that are autodetected (this is bug 70222). So some decent fallback/autodiscovery *is* needed to solve bug 70222 and bug 68331; if there is any issue in the Vagrant packaging with skin detection we should know that as well. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
