https://bugzilla.wikimedia.org/show_bug.cgi?id=68887

--- Comment #8 from Matthew Flaschen <[email protected]> ---
(In reply to Nik Everett from comment #7)
> Nah, an empty search results object isn't falsy in this case.  Its an object
> rather than an array.  Though, you are right it'd be more clear to check for
> null directly.  You want to send a patch :) ?

I wasn't thinking of weak type equality issues, but rather
https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCirrusSearch.git/bc8ac094eaa9ebbc22de44667c4ea97ca0fb70b4/includes%2FCirrusSearch.php#L61
:

* @return Search\ResultSet|null|Status results, no results, or error
respectively

which apparently indicates (second in list on both sides) that null means "no
results":

> Also, some proof:
> https://it.wiktionary.org/w/index.
> php?title=Speciale%3ARicerca&profile=default&search=ulteriori+informazioni&fu
> lltext=Search

Thanks for reassuring me.

That feature is awesome, by the way.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to