[Bug 70462] New: CentralNotice: Don't load closeWindow19x19.png from Wikimedia servers

Fri, 05 Sep 2014 14:03:47 -0700 

https://bugzilla.wikimedia.org/show_bug.cgi?id=70462

            Bug ID: 70462
           Summary: CentralNotice: Don't load closeWindow19x19.png from
                    Wikimedia servers
           Product: MediaWiki extensions
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Keywords: performance
          Severity: normal
          Priority: Unprioritized
         Component: CentralNotice
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected], [email protected]
            Blocks: 700
       Web browser: ---
   Mobile Platform: ---

A bit odd to see it load an image from a url.

> $wgNoticeCloseButton = 
> '//upload.wikimedia.org/wikipedia/foundation/2/20/CloseWindow19x19.png';

The image is part of MediaWiki core, so there's a stable url it could use to
load it from the local wiki (it's in skins/common/).

But instead of loading it from the local wiki, or from bits.wikimedia.org, or
Wikimedia Commons, it loads it from foundationwiki.

Let's not do that. Since skins/common has been deprecated, this should just be
added to  the extension.

Better yet, why is it configurable? Sounds like it shouldn't be an <img>
either, but just somewhere in a CSS background-image, with @embed for automatic
optimised loading via ResourceLoader (embedded in CSS, no extra http request).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to