https://bugzilla.wikimedia.org/show_bug.cgi?id=68599

--- Comment #4 from Kunal Mehta (Legoktm) <[email protected]> ---
(In reply to Sam Reed (reedy) from comment #3)
> https://github.com/wikimedia/mediawiki-extensions-MassMessage/compare/
> contenthandler
> 
> So looking at MassMessagehooks.php
> 
> $out->addModuleStyles( 'ext.MassMessage.content' );
> $out->addModules( 'ext.MassMessage.content.js' );
> 
> A module ending in .js just feels icky. That's alright though, as the 2
> should be merged, and then we can just have:
> 
> $out->addModules( 'ext.MassMessage.content' );

We have to do that so the CSS styles are still served to users with JS
disabled. Modules loaded via addModules require JS. Also there would be a FOUC
iirc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to