https://bugzilla.wikimedia.org/show_bug.cgi?id=70605

            Bug ID: 70605
           Summary: fix problems found by rubocop in mediawiki/ruby/api
                    repo
           Product: Wikimedia
           Version: wmf-deployment
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Quality Assurance
          Assignee: wikibugs-l@lists.wikimedia.org
          Reporter: zfili...@wikimedia.org
                CC: cmcma...@wikimedia.org, dduv...@wikimedia.org,
                    zfili...@wikimedia.org
       Web browser: ---
   Mobile Platform: ---

- clone mediawiki/ruby/api repo[1]
- install rubocop gem[2]
- run "rubocop --auto-gen-config"
- commit .rubocop.yml and .rubocop_todo.yml files to the repo
- push the commit to gerrit (with "git review")

- create separate commit(s) that solve the problems found by rubocop
- feel free to group similar or small problems in one commit
- make sure none of the commits is too big, so reviewers do not have a hard
time

- add me (zfilipin) as a reviewer to every commit that is pushed to gerrit

1: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/ruby/api
2: https://rubygems.org/gems/rubocop
3: https://github.com/bbatsov/rubocop#automatically-generated-configuration

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to