https://bugzilla.wikimedia.org/show_bug.cgi?id=21692
--- Comment #18 from Matthew Flaschen <[email protected]> --- (In reply to Helder from comment #15) > Shouldn't we keep this bug until the method documented at > https://www.mediawiki.org/wiki/Extension:WikiEditor/ > Toolbar_customization?diff=639169 > also works with LQT? > > Or maybe that method should be deprecated? > As far as I know, it is only used by the GuidedTour extension: > https://github.com/wikimedia/mediawiki-extensions-GuidedTour/blob/ > 127888bf108379dcea5d7ee60272f431f889aa7e/modules/ext.guidedTour.lib.js#L765 The bug is that LQT does not support user toolbar customization, or at least not in the same way as WikiEditor. That hook (wikiEditor-toolbar-doneInitialSections) is a way of knowing when the initial WikiEditor toolbar buttons are done loading. GuidedTour needs this because the toolbar load causes (or at least did back then) a reflow. I don't support deprecating it until there's an adequate replacement, or it's established that the current version of WikiEditor never causes reflows when the toolbar loads. I haven't tested it, but it looks like there is now a way to know when LQT is ready for customization, or at least when the textarea is ready (ext.lqt.textareaCreated). Thus, the only reason to keep this open would be if it doesn't work or you believe that it should use the same hook as WikiEditor. I don't know enough about the architecture of either WikiEditor or LQT to know if they should use the same hook. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
