https://bugzilla.wikimedia.org/show_bug.cgi?id=70351

--- Comment #11 from Isarra <zhoris...@gmail.com> ---
(In reply to Matthew Flaschen from comment #10)
> (In reply to Isarra from comment #9)
> > Sure, the colour-coded buttons according to their function are nice, but 
> > not everyone cares.
> 
> And yet someone complained about *not* having them at bug 47698 (see also
> bug 55554, where this was brought up again and the colors were added to
> non-Vector), because the alternative was gray.

That was when overriding the default styles. I'm saying not all skins will even
want to do that. 

That being said, this also comes up with regard to js gadgets, which will often
use special buttons even when the skin may not, and they will need a sane
coloured button default.

> Bear in mind that "no MW UI styles" at all may not always do what you want. 
> For example Special:UserLogin has a "Join $SITENAME" button.  However, it's
> really just a styled link, so if it's completely unstyled it will look like
> a link.

And what's wrong with having a simple link when you're going for low-key? To
take it even further, I've designed a skin where the login form didn't look
like a form at all, but just a page you write your credentials on. But that was
for a game, and in the context of the game, that made sense.

There are a lot of ways these things can go.

> So rather than debate between "no MW UI styles" and "current MW UI styles"
> for e.g. FooSkin, I'd rather support people who want to make appropriate
> styles for FooSkin (unless there's a broad consensus that FooSkin should
> have either "no MW UI styles" or "current MW UI styles"; honestly not many
> people have voiced opinion on which of the three).

All three should be options. We need a sane default (in core, that can be used
by whatever skin if desired, and will be included in the main one(s)) as well
as something to be included as the initial example for new skins (as in, with
the Example skin), however. Currently we have neither of these.

Theming extensions should also be able to apply common/new MW UI styles to
skins, if needed, however. This would be useful for site branding in
particular, because then an organisation could take a generic skin like vector
and easily apply their own branding to everything. This could also be a way for
the WMF to start distinguishing its own wikis from everyone else's using the
default skins.

> > Is there any documentation on how to do that, or use the underlying
> > framework? From where I'm standing it looks like the only option is to
> > manually override all the styles, and when they keep changing and getting
> > more complex, that's pretty horrible.
> 
> The basic tool is
> https://www.mediawiki.org/wiki/Manual:$wgResourceModuleSkinStyles , along
> with the discussion above about whether you're augmenting or replacing
> styles (that is important re what I said about 'default').
> 
> Importantly, there are also mixins at
> https://git.wikimedia.org/tree/mediawiki%2Fcore.git/
> e2e6f7767ef58659904422c36d390c230b59852f/resources%2Fsrc%2Fmediawiki.less
> which you can use (note the mediawiki.less/mediawiki.ui directory, which has
> mixins and variables).  These can be imported with e.g.:
> 
> @import "mediawiki.ui/variables";

But if that's variables, what about the framework? What all can we change? How
do we include the js for the form elements (since a lot simply CANNOT be styled
with css alone)? How do we create our own styles from the ground up, not just
change some colours and crap? Or is that all in there somewhere?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to