https://bugzilla.wikimedia.org/show_bug.cgi?id=70843

--- Comment #5 from Bryan Davis <[email protected]> ---
(In reply to Dan Duvall from comment #4)
> (In reply to Bryan Davis from comment #3)
> > I think this is a bug in hhvm actually. Read that documentation link you
> > gave and you'll see that php5-cli defaults to "0" for this as can be seen
> > with the php5 binary:
> 
> AFAICT there's no bug. We're explicitly setting it to 180 on the first line
> of /etc/hhvm/php.ini which affects the execution limit in all contexts.
> Remove that line and you get the expected value of 0 from the command line.

The bug it is the difference in behavior between php and hhvm. Php5 ignores any
ini setting for max-execution-time when executing in cli mode. You can see this
by checking /etc/php5/cli/php.ini on your MW-Vagrant VM or a production host.
"max_execution_time = 30" is included in that file, but the CLI SAPI entry
point will ignore it and give the unlimited result when queried. This behavior
is documented a little more clearly at
<http://php.net/manual/en/features.commandline.differences.php> than it is on
the ini settings page.


> You're right though, I should have read more closely. Since the default for
> CLI is 0 we probably shouldn't be messing with it. It looks like we may be
> able to move that setting to /etc/hhvm/server.ini. [1] Does that seem
> reasonable (if it works)?
> 
> [1] https://github.com/facebook/hhvm/wiki/INI-Settings

We can probably work around the problem by making changes to bring the hhvm
configuration used in MW-Vagrant into sync with the configuration that has been
done for production
<https://github.com/wikimedia/operations-puppet/blob/production/modules/hhvm/manifests/init.pp>.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to