https://bugzilla.wikimedia.org/show_bug.cgi?id=23258
--- Comment #7 from Tim Starling <[email protected]> 2010-06-23 01:11:04 UTC --- (In reply to comment #4) > There's no reson not to rename and/or mere it with core. Well actually, there > is one: They do like to be visible on Special:Version. Not sure if adding the > extension authors to the core credits would be an option. We can add them to the core credits. > The cache thing is an akward hack to provide for broken legacy files. We > already have several thousand tiff files uploaded, some of which we'll not be > able to render. Caching the fact that extraction failed for a specific file is > supposed to prevent mediawiki trying to extract that info over and over again, > whenever the file or a thumbnail is requested. The correct way to do this is to save an error value into the metadata blob. See how OggHandler does it. > Considering the comment you added later, it seems that using img_shrink is > always ok? did I understand that correctly? Yes, and further testing showed that it produces far better visual results than img_resize_linear when downscaling by a significant factor. I'll add attachments to show what I mean. > Not sure what you are getting at here - does this mean ImageMagick's scaling > looks better? Yes, ImageMagick has done a much better job of this in terms of visual results. It just uses far more memory. I'm pretty sure now that it's best to use VIPS im_shrink to scale down to an intermediate size, and ImageMagick to go down to web size. > wow... uh... why? i mean, just adding "height" would have been cleaner and > simpler, no? I'm not sure how that would be possible. Magic words define syntax, not handler parameters. We don't really want to have [[Image:Foo.png|width=100px|height=100px]]. Maybe it's just the name (img_width) that is offending you? If it had been called img_width_height would it have been better? > Thank you very much for clarifying this. It's quite confusing how these > methods interact. What would be a good place to document this? MediaHandler (in Generic.php). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
