https://bugzilla.wikimedia.org/show_bug.cgi?id=71070
Bug ID: 71070
Summary: QA: qunit test should have caught ext.flow.new error
Product: MediaWiki extensions
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Flow
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected], [email protected],
[email protected]
Web browser: ---
Mobile Platform: ---
Check out 0e560b8 (enwiki 1.24wmf21 as of 2014-09-12) and load a Topic, it
exhibits Bug 71054 error in browser console. ResourceLoader knows something
went wrong, `mw.loader.getState( 'ext.flow.new' )` prints "error".
We should figure out why qunit tests didn't catch this and fix or add a test.
qunit has a built-in test for failed RL modules
<https://git.wikimedia.org/blob/mediawiki%2Fcore.git/3daf61814db326f81c612186754f545c0548501e/tests%2Fqunit%2Fdata%2Ftestrunner.js#L442>.
If I load by hand with mw.loader.getState('ext.module.new') there's no error, I
guess there's some specific interaction on Topic: that a qunit test needs to
mimic. (I'm also confused why
https://test2.wikipedia.org/wiki/Special:JavaScriptTest/qunit doesn't run
extension qunit tests.)
I'll file a separate bug to add
step "page has no ResourceLoader errors"
to Topic loading in tests/browser
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
