https://bugzilla.wikimedia.org/show_bug.cgi?id=70351

--- Comment #26 from Matthew Flaschen <[email protected]> ---
(In reply to Isarra from comment #25)
> > That's your opinion.  No other skin writers have expressed that opinion, as
> > far as I know.
> 
> Jack Phoenix (who probably holds the record on number of skins created and
> maintained) agrees; he just gave up on trying to argue with people about
> skin-related things long ago because nobody ever listens.

Thanks, that's good to know.  Has he commented as such publicly?

> > I don't understand what part of the backend you feel blocks your work on an
> > alternative skin for MediaWiki UI.
> 
> mwui has to have some kind of framework for the form elements, or it would
> be impossible to reliably style anything beyond the buttons (css is just not
> that well supported for form elements on all browsers). But I've seen other
> form elements in the prototypes. How was this done?

I'm not sure what you mean by framework.  We're not using any third-party
libraries (except for the LESS implementation itself,
http://leafo.net/lessphp/).  It is all standard LESS.  It does include use of
mixins (a function that can be used to reuse CSS/LESS code) and variables.

For things like mw-ui-checkbox, it just uses clever LESS, compiling to CSS. 
See
https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/resources%2Fsrc%2Fmediawiki.ui%2Fcomponents%2Fcheckbox.less
.

The markup for that actually is relatively standard too, just with a wrapping
div:

<div class="mw-ui-checkbox">
  <input name="someInput" value="1" id="someInput" type="checkbox">
  <label for="someInput">The label for the input</label>
</div>

(In reply to Isarra from comment #23)
> (In reply to Matthew Flaschen from comment #21)
> > Vector (the default skin) is going to continue with the current style, and
> > it will also remain the default style until there's a consensus on another
> > default.
> 
> Where was the consensus for the current style?

I'm talking about consensus on the issue of whether it should be Vector-only,
vs. the default implementation.

1. We tried minimalistic styles for MediaWiki UI in non-Vector skins, and
people objected that they didn't look like Vector

MZMcBride: "The blue button is no longer blue. [...] Why is it acceptable to
use the blue and green in Vector but not in Monobook? [...] Vector and Monobook
are very similar in design. I don't understand why it's acceptable to use
bright green and blue in Vector, but not in Monobook." (bug 47698)

Dan Garry: "Coloured buttons are important as part of a move we're doing
towards making Wikimedia sites have a more fluid user experience, so it'd be
great if MonoBook could be modified to incorporate those." (bug 55554)

(Both of the bugs have comments from other people, too, obviously).

2. Most importantly, no one has mocked up or implemented what alternative
implementation it should like by default.  Rough Consensus and Running Code (or
Running Styles as the case may be).

If you want to do a pure mockup (no CSS or LESS yet, just a drawing), the
various sections of https://tools.wmflabs.org/styleguide/desktop/index.html are
good things to mock up.

You also did not reply to my point that "no styles whatsoever" causes you to
completely lose features:

"There is no native browser control for buttons with both icons and text
(AFAIK) (or various other things that will be coming).  In other words, there
is no classic styling for this, and no previous styling since we never had this
feature in the old days."

Note this is now merged (https://gerrit.wikimedia.org/r/#/c/158632).  Simply
dropping all MW UI would break this feature.

If we did choose a more minimalist default (which I would be more supportive of
if I confirm it's backed by more than one skin writer), I would probably keep
Vector and Monobook the same for now, given the above.  I'm not sure how best
to implement that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to