https://bugzilla.wikimedia.org/show_bug.cgi?id=71570

Florian <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |florian.schmidt.welzow@t-on
                   |                            |line.de

--- Comment #3 from Florian <[email protected]> ---
This seems to be because of how Alpha and stable recognize, if a talk button is
useful or not. If the user has no JS enabled, the talk button should be hidden,
if there is no talk page (the user can't create a page without JS in mobile)

For this there are these implementations:

Stable:
Check if the talk element has a new class:
https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/skins/SkinMinerva.php#L725
(with flow, there will be never a new class?!)

Alpha:
https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/skins/SkinMinervaAlpha.php#L74
Decide with the number of topics (which will be displayed in the talk icon).
So, Flow never returns the number of topics, if i see this right, so the talk
button will be hidden every time.

talk.js isn't loaded on pages with flow talk pages, too (?!), so the hidden
class will never be removed, like it will be on "normal" talk pages :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to