https://bugzilla.wikimedia.org/show_bug.cgi?id=71945
Bug ID: 71945
Summary: MediaWiki UI shows unintentionally on Categories and
Contributions due to incorrect use of getConfig return
value
Product: MediaWiki
Version: 1.25-git
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: MediaWiki UI
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected]
Web browser: ---
Mobile Platform: ---
Flags: Backport_WMF?
This affects wmf/1.25wmf2 (currently on all Wikipedias) but not 1.25wmf3 or
master. It happened to get fixed by a155ac55ea0854b0989efe23158d33b5a548f14e .
Basically, Special:Categories and Special:Contributions were calling:
if ( $this->getConfig( 'UseMediaWikiUIEverywhere' ) ) {
(passing an unused parameter to a no-args method, then using the config object
as a boolean)
instead of the correct:
if ( $this->getConfig()->get( 'UseMediaWikiUIEverywhere' ) ) {
I think we should backport the fix on Monday (it can be done by making the
above change rather than the whole a155ac55) since it's very inconsistent (only
the button is MW UI, not the text boxes or checkboxes) and
Special:Contributions is a prominent page.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
