https://bugzilla.wikimedia.org/show_bug.cgi?id=71249

--- Comment #4 from Alex Monk <[email protected]> ---
(In reply to James Forrester from comment #3)
> (In reply to Alex Monk from comment #1)
> > Currently the redirect section of the page settings dialog and the template
> > placeholder page use MWTitleInputWidget.
> > 
> > The template placeholder page can be fixed with a simple change from value
> > === '' to !mw.Title.newFromText( value ) in
> > MWTemplatePlaceholderPage#onTemplateInputChange. It will no longer allow you
> > to add a template with an invalid name. No need for isValid here.
> 
> What happens when you use a parser function or a magic word?

I imagine it would break. So let's not do that.

> > As for the redirect settings, that seems more difficult. I don't think we
> > should just silently ignore the value if it was set to an invalid title...
> > And I don't think we should disable the apply button either.
> 
> We show "invalid title" for link searches; presumably that's evaluated
> server-side?

That is shown when the page does not seem to exist (based on the search
results) and we get a false-y value from mw.Title.newFromText on the given
title.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to