https://bugzilla.wikimedia.org/show_bug.cgi?id=64294

Marcel Ruiz Forns <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |PATCH_TO_REVIEW

--- Comment #1 from Marcel Ruiz Forns <[email protected]> ---
This is already working.

See stdout when executing 'alembic upgrade HEAD' in these 2 cases:

1) When 'DEBUG = True' in ./wikimetrics/config/db_config.yaml, output is:

INFO  [alembic.migration] Context impl MySQLImpl.
INFO  [alembic.migration] Will assume non-transactional DDL.
Running migration for wikimetrics
INFO  [alembic.migration] Context impl MySQLImpl.
INFO  [alembic.migration] Will assume non-transactional DDL.
Running migration for wikimetrics_testing

2) When 'DEBUG = False' in ./wikimetrics/config/db_config.yaml, output is:

INFO  [alembic.migration] Context impl MySQLImpl.
INFO  [alembic.migration] Will assume non-transactional DDL.
Running migration for wikimetrics

This code is performing the action (./database_migrations/env.py):

    config = db.config
    engine = get_engine(config)
    migrations = [(engine, target_metadata)]

    if db.config['DEBUG'] is True:
        test_config = setup_testing_config(deepcopy(config))
        test_engine = get_engine(test_config)
        test_metadata = db.WikimetricsBase.metadata
        migrations.append((test_engine, test_metadata))

I deduce that nothing more needs to be done for this bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to