https://bugzilla.wikimedia.org/show_bug.cgi?id=5125
--- Comment #13 from Chad H. <[email protected]> 2010-07-10 09:01:23 UTC --- (In reply to comment #12) > Goodness, I'd forgotten I'd written all this. > Lots of installer bugs are old. None of the patches on them apply to the new installer. > I find your conclusion nonsensical - My changes for 1 above does not amount to > customization, merely that making the definition only in one place (aka DRY), > which is just good coding practice IMHO. WHEN you decide to change it, > chances > are you'll write code that does pretty much the same thing. Either that or > invite disaster by making changes in multiple locations. > /config isn't hardcoded in a bazillion places these days. It wouldn't be hard to find and fix the few manual usages. Like I said above, if we decide to change where the entry point is, that's being discussed at bug 1379 > 3 directly conflicts with 2: you say that writing to config is dangerous > (which > is why SF doesn't allow it), but then refuse to provide a workaround. Writing to /config isn't safe. Neither is writing to /foobar or /mysecretinstaller. Changing the directory does nothing to mitigate the issue. We don't want the web server being the owner of the config file at all. See http://www.mediawiki.org/wiki/New-installer_issues?diff=334526&oldid=333913 for more information. >Also, > again my changes really only amount to making this so it's set only in once > place, it doesn't represent any change in policy. Allowing someone to hack the > path simply (for example so it writes somewhere that's writable but not under > the web root) seems like a handy side effect. > > To summarise: my patch would: > > a) simplify changing paths used by mediawiki and make doing so safer and more > reliable, pre-emptively fixing future bugs in that area > b) have a side effect of making changing them again easier, even though that > may not be the primary aim > c) make mediawiki installations on sourceforge easier > To summarize, we're changing the installer so that you no longer have the web server writing the config file. So customizing it is no longer an issue :) > I'm mystified why you'd not want this fix; the alternative means you're > deliberately choosing to live with bad code for no good reason. You haven't seen the new installer, have you? The code is far better than when you submitted that patch ;-) http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/installer/ -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
