tstarling created this task. tstarling claimed this task. tstarling added a subscriber: tstarling. tstarling added a project: MediaWiki-Core-Team. tstarling moved this task to To Do on the MediaWiki-Core-Team workboard. tstarling changed Security from none to none.
TASK DESCRIPTION HHVM PCRE cache needs rewriting. * m_overflow is just for deallocation -- once the shared cache is full, every call to preg_match() causes another compilation * StaticString leakage, even when the shared cache is full. This is apparently a workaround for AtomicHashArray's key limitations "You must use atomically compare-and-swappable integer keys, or a different container class." * AtomicHashArray is complex but very limited: no LRU, size limit baked in, "Can grow to a maximum of about 18 times the initial capacity, but performance degrades linearly with growth." * Only item count is accounted for, size not accounted for in capacity limit There's absolutely no chance of rewriting MediaWiki such that it doesn't eventually exhaust the shared regex cache. Existing HHVM bug report: https://github.com/facebook/hhvm/issues/1182 TASK DETAIL https://phabricator.wikimedia.org/T757 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. To: tstarling Cc: wikibugs-l, tstarling _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
