https://bugzilla.wikimedia.org/show_bug.cgi?id=24315

--- Comment #7 from Chad H. <[email protected]> 2010-07-14 14:46:37 UTC 
---
(In reply to comment #5)
> There are currently performance implications with using this with diffonly=0. 
> We're working on fixing those, but they won't entirely go away.

Once we get that sync'd, I consider it a non-issue. The wider question of
caching parser output of older revs like we discussed the other day is way
beyond the scope of this bug.

(In reply to comment #6)
> Eh, no. I have switched on "diff only" in every wiki I have ever used, and yet
> I requested the original change here. And I even backed that with arguments,
> not with "wants".
> 

I agree with what you're saying. I'd actually suggest we WONTFIX this in favor
of keeping the behavior as requested in bug 14828

> And this change has been active on dewp for almost two years, which seems to
> suggest that the reasoning wasn't *that* bad.
> 

That's a pretty convincing argument as well.

> So it would be really nice if the almighty "performance implications" could be
> explained a bit more detailed: How can something that worked on dewp for 
> almost
> a million articles for almost two years melt the servers on enwp with less 
> than
> 2000 articles (and, at this moment, three (3) articles on
> Special:OldReviewedPages)?

It didn't "melt the servers" :)

As explained on bug 24124, when viewing a diff, the preview of content under
the diff was being parsed on every diff view and not using the parser cache.
When viewing a diff to the current rev, which is a very common scenario, I
changed it in r69191 to use the parser cache. 

It's only a fix for a single scenario (diffing to cur), but it's a fairly
common scenario in the enwp setup for FlaggedRevs so it should provide a
noticeable difference. And it'll be generally useful whenever someone diffs to
cur.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to