https://bugzilla.wikimedia.org/show_bug.cgi?id=72315
Roan Kattouw <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Assignee|jforrester+veteambztickets@ |[email protected] |wikimedia.org | --- Comment #4 from Roan Kattouw <[email protected]> --- (In reply to Alex Monk from comment #3) > This seems to be because the first undo you make only clears the comment > -text- change. The second undo actually removes the comment node itself. > This makes sense since you make the comment node and it goes in the document > first, then later insert some text into it. > ContextItemWidget#getDescription falls back to the tool's title if the text > was falsey (so, an empty string), which is why you see 'Comment' rather than > an empty box. This also seems reasonable. > > We should probably be removing an empty comment node from the document if > it's left there due to undo... Currently this only appears to be done if you > have an open comment inspector with no text and then click outside it (see > CommentInspector#getTeardownProcess). This sounds like it was caused by Ed's "staging empty comment node" change. That code should ensure that the creation of the comment node and setting the value are one entry in the undo stack. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
