https://bugzilla.wikimedia.org/show_bug.cgi?id=35342

--- Comment #53 from Derk-Jan Hartman <hartman.w...@gmail.com> ---
Paladox, I'm not sure how I need to explain this to you and it hope it doesn't
come across as rude, because it's not intended to be that way, but this whole
stuff is simply not reviewable right now.

If I go trough a patchset, read the commit message and the diff, test it in my
browsers and NOT have all my questions answered. It cannot be merged.

Things I should not have to do are:
1: Go trough 50 patchset rebases
2: Go trough 15 comments interspersed with these rebases, for finding answers
that should be in the commit message, if they affect the review.
3: Pick and choose between 3 patchsets, for one change.


This Bug ticket is about converting the Original PNGs to SVG.
1: M4tx did some nice work
2: This work was not pixel perfect with the original PNGs, but that was fine
3: I approved the SVG change on that basis
4: It turned out that there were problems with the SVGs in production. This
should have been cause for reverting the change.
5: Instead of reverting I gave people a chance to fix it, Pro, you etc.
6: You currently are the one making those proposals for changes.
7: You can't answer the questions in a way that gives enough people confidence
to approve the changes. (either by lack of experience, by lack of your mastery
of the language, of not actually being able to prove it all works as expected
etc.)
8: This means the patches cannot be merged, and that means that it's about time
to bite the bullet, and I need to admit that I should have reversed the
original commit back then when it became clear there were some problems with
the original change to SVG.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to