https://bugzilla.wikimedia.org/show_bug.cgi?id=72557
Bug ID: 72557
Summary: MultimediaViewer pollutes user_properties with empty
strings
Product: MediaWiki extensions
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: Unprioritized
Component: MultimediaViewer
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected], [email protected]
Web browser: ---
Mobile Platform: ---
mysql:[email protected] [commonswiki]> select up_value,
count(*) from user_properties where up_property = 'multimediaviewer-enable'
group by up_value;
+----------+----------+
| up_value | count(*) |
+----------+----------+
| | 8 |
| 1 | 324 |
+----------+----------+
2 rows in set (0.65 sec)
The property is set via AJAX, and while there is already a fair amount of
trickery in selecting the right value, it apparently still not works, and sets
the value to an empty string on opt-out for wikis where opt-out is the default,
when actually it should just delete the row.
The proper fix will probably involve setting
$wgDefaultUserOptions['multimediaviewer-enable'] to 1 instead of true.
An empty string and a missing row is handled the same way by the software, so
this is a minor issue; at worst it might confuse stats scripts.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
