https://bugzilla.wikimedia.org/show_bug.cgi?id=70585
--- Comment #1 from Aaron Schulz <[email protected]> --- Some bits: * I don't like the unbounded cache in displayGlobalPage() * Seems like brokenLink() could check 'known' earlier to avoid DB queries (the link methods are fairly hot) * displayGlobalPage() loads user prefs to check 'globaluserpage' but we don't have global preferences on * The "if ( !trim( $parsedOutput['text']['*'] ) ) {" should use a regex or something to avoid copying the HTML string in memory (nitpick) * getCentralTouched() has an unbounded cache and does not call reuseConnection() * memcached key in getRemoteParsedText() could be too long * Are we using $wgGlobalUserPageAPIUrl? If so, can it be configured to avoid API queries? Maybe a timeout should be set for MWHttpRequest? The default $wgHTTPTimeout might be a bit high. Also, what happens when it fails? I guess you get warnings and null would get cached (the cache value check uses "!== false"). Maybe the cache period could be reduced in that case and warnings avoided. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
