https://bugzilla.wikimedia.org/show_bug.cgi?id=72717
Bug ID: 72717
Summary: VisualEditor: Clicking in a table that contains
templated rows causes JS error
Product: VisualEditor
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: critical
Priority: Unprioritized
Component: Data Model
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected],
[email protected]
Web browser: ---
Mobile Platform: ---
1. Go to
http://en.wikipedia.beta.wmflabs.org/wiki/User:RoanKattouw/Evil_table?veaction=edit
2. Click on a non-templated cell in the table (e.g. the cell that says "simple"
in row 2)
3. "undefined is not a function" error appears in console
What happens is that TableMatrix#update runs, and when it hits cell (2,0) (3rd
row, 1st column), it will find that cellNode is a ve.dm.MWTransclusionNode
rather than a ve.dm.TableCellNode, and so calling .getRowSpan() on it will
explode.
We probably need some way to deal with templated rows/cells in the middle of an
otherwise normal table, but I'm not entirely sure what that should look like.
Maybe we can get away with skipping over these rows/cells everywhere in a
consistent manner, and hopefully that will work out OK?
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
