https://bugzilla.wikimedia.org/show_bug.cgi?id=72879
Bug ID: 72879
Summary: support statements on properties in changeops
Product: MediaWiki extensions
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: WikidataRepo
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected]
Web browser: ---
Mobile Platform: ---
While https://gerrit.wikimedia.org/r/#/c/170576/ addresses this issue in
ChangeOpClaim, we have use of $entity->getClaims() in other ChangeOp classes:
./ChangeOpClaimRemove.php: $claims = new Claims( $entity->getClaims() );
./ChangeOpMainSnak.php: $claims = new Claims( $entity->getClaims() );
./ChangeOpQualifier.php: $claims = new Claims( $entity->getClaims() );
./ChangeOpQualifierRemove.php: $claims = new Claims( $entity->getClaims() );
./ChangeOpReference.php: $claims = new Claims( $entity->getClaims() );
./ChangeOpReferenceRemove.php: $claims = new Claims( $entity->getClaims() );
./ChangeOpsMerge.php: foreach ( $this->fromItem->getClaims() as
$fromClaim ) {
./ChangeOpsMerge.php: foreach ( $this->toItem->getClaims() as $claim ) {
./ChangeOpStatementRank.php: $claims = new Claims( $entity->getClaims() );
For an Item, that returns claims. For Property, getClaims() is not implemented
so uses Entity::getClaims which returns an empty array!
This is going to be problematic for statements on properties, as well as
perhaps other issues in ChangeOps. (and simply the confusion about Claims vs.
Statements, since the api modules are called things like 'wbsetclaim')
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
