https://bugzilla.wikimedia.org/show_bug.cgi?id=66202

--- Comment #7 from Masin Al-Dujaili <[email protected]> ---
Meanwhile, I have been told extensions shouldn't use Parser::parse() at all but
rather Parser::recursiveTagParse(). So I changed those lines in
SF_FormUtils.php to:

        $output = $parser->recursiveTagParse( $form_def );
        $form_def = $stripState->unstripGeneral( $output );

As I don't fully understand the neccessities of the following lines, I
commented them out. recursiveTagParse does not return a ParserOutput object, so
adapting those lines doesn't look feasible at all.

/*        if ( $output->getCacheTime() == -1 ) {
            $form_article = Article::newFromID( $form_id );
            self::purgeCache( $form_article );
            wfDebug( "Caching disabled for form definition $form_id\n" );
        } elseif ( $form_id !== null ) {
            self::cacheFormDefinition( $form_id, $form_def, $parser );
        }*/

Result: Works as well with our usecase. There might be some ratio to using
Parser::parse() instead of Parser::recursiveTagParse() but I can't see it at
the moment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to