https://bugzilla.wikimedia.org/show_bug.cgi?id=72778

--- Comment #9 from Bryan Davis <[email protected]> ---
(In reply to Bryan Davis from comment #8)
> Ori pointed out that the CMake rules will use a shared libjson-c library if
> present and the WMF HHVM build is using that:
> 
> $ ldd /usr/bin/hhvm |grep json
>         libjson-c.so.2 => /lib/x86_64-linux-gnu/libjson-c.so.2
> (0x00007ff80354e000)
> 
> I haven't investigated yet if this would change json_decode() to be lenient
> by default, but it is a possibility.

Libjson-c is lenient by default
<https://github.com/json-c/json-c/blob/d4e81f9ec8273914739808737fa0a27a3f0589fb/json_tokener.h#L90-L100>
and this is not changed by HHVM
<https://github.com/facebook/hhvm/blob/a82234b63e86d57026db719e533225f25f103127/hphp/runtime/ext/json/jsonc_parser.cpp#L225-L227>.
This combination means that the behavior of json_decode() changes depending on
how HHVM is compiled/linked.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to