https://bugzilla.wikimedia.org/show_bug.cgi?id=58279

--- Comment #27 from Krinkle <krinklem...@gmail.com> ---
(In reply to Bawolff (Brian Wolff) from comment #26)
> (In reply to Bawolff (Brian Wolff) from comment #25)
> > Re-opening. I just managed to submit a patch (
> > https://gerrit.wikimedia.org/r/#/c/147754/ ) with a rather stupid json
> > error, and jenkins did not complain.
> 
> Its been pointed out to me that the jslint job (which is non-voting on
> TimedMediaHandler) is what verifies json files (Although
> https://integration.wikimedia.org/ci/job/mwext-TimedMediaHandler-jslint/497/
> consoleText doesn't seem to say anything about an i18n file failing). I'd
> like to suggest that the job be split. As missing a coding convention and a
> fatal error are rather different types of issues.

I agree it shouldn't be part of the jslint job. But I don't think we should
change that for the time being. The jslint job in general is an older one that
is being phased out by having projects adopt Grunt instead. Where they can add
jshint, jscs, banana-checker, and (if they have non-i18n json files) json-lint
to their pipeline.

TMH repo should be updated by adding the appropriate jshint config and ignores
so that their non-voting exemption may be lifted. Because right now, obvious
syntax errors in javascript files aren't caught, either. Which is just as
important as json syntax errors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to