https://bugzilla.wikimedia.org/show_bug.cgi?id=73677

            Bug ID: 73677
           Summary: OOUI: Get rid of inline styles in LabelElement
           Product: OOjs UI
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Technical Debt
          Assignee: jforrester+veteambztick...@wikimedia.org
          Reporter: matma....@gmail.com
                CC: jforres...@wikimedia.org, krinklem...@gmail.com
       Web browser: ---
   Mobile Platform: ---

We should get rid of inline styles in LabelElement.

this.$label.css( 'display', !label ? 'none' : '' );

$this->target->setAttributes( !$label ? array( 'style' => 'display: none;' ) :
array() );

Trevor Parscal <tpars...@wikimedia.org> wrote:
> I think this is dumb, it should be done by removing oo-ui-labeledElement  
> the same way we do with icons and indicators - and in all 3 cases this  
> should be done at a higher and more general level. Nonetheless, the  
> point is if you make the label empty empty empty (see first case from  
> above) we want to avoid styles being applied to it (probably?).
>
> I'm less sure about this case, as you can see, but for compatibility  
> don't want to change it until we have a cohesive plan.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to