Summary: Update FlaggedRevs for new categorylinks schema
           Product: MediaWiki extensions
           Version: any
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: Normal
         Component: FlaggedRevs

FlaggedRevs uses cl_sortkey, so it might be broken by the categorylinks changes
<>.  I
looked at the code and wasn't immediately sure what it was doing, so I wasn't
sure how to fix it.  If someone who knows more about FlaggedRevs could either
fix it or say what needs to be done or say what FlaggedRevs uses categorylinks
for, please do.

Important changes are:

1) The (cl_to, cl_sortkey, cl_from) index was changed to (cl_to, cl_type,
cl_sortkey, cl_from).  This means that SELECT ... WHERE cl_to = 'Foo' ORDER BY
cl_sortkey; will cause a filesort.  It would need to be changed to ORDER BY
cl_type, cl_sortkey, or have AND cl_type = 'page' added, or something. 
(cl_type is a new ENUM equal to either 'page', 'subcat', or 'file' depending on
the namespace of cl_from.)  Likewise if you have offsets, those would need to
include cl_type too to use the index properly.

2) cl_sortkey is now a binary string, at least in principle.  Right now it's
mostly text but could have embedded nulls; in the future it will likely be
changed to pure binary sortkeys generated by CLDR or something.  If you're
printing these or anything, don't.

Possibly no changes are needed, I'm not sure.

Configure bugmail:
------- You are receiving this mail because: -------
You are on the CC list for the bug.

Wikibugs-l mailing list

Reply via email to