https://bugzilla.wikimedia.org/show_bug.cgi?id=25504

--- Comment #4 from Aaron Schulz <jschulz_4...@msn.com> 2010-10-13 01:47:51 UTC 
---
(In reply to comment #0)
> Actually I'm not sure if I'm not wrong, because I thought something like this
> should cause a crash, so maybe it's ok, but...
> 
>                 $pass = self::editSpacingCheck(
>                     $wgFlaggedRevsAutoconfirm['spacing'],
>                     $wgFlaggedRevsAutoconfirm['benchmarks'],
>                     $user
>                 );
>                 # Make a key to store the results
>                 if ( !$pass ) {
>                     $wgMemc->set( $APSkipKey, 'true',
>                         3600 * 24 * $spacing * ( $benchmarks - $needed - 1 ) 
> );
>                     return true;
>                 } else {
>                     $wgMemc->set( $sTestKey, 'true', 7 * 24 * 3600 );
>                 }
> 
> 
> $spacing, $benchmarks and $needed seem to be local variables in
> self::editSpacingCheck(). As far as I can see there are no such variables in
> the current scope. Or are there?

Fixed in r74710

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to