https://bugzilla.wikimedia.org/show_bug.cgi?id=25827

           Summary: includes/DefaultSettings.php has two different
                    defaults for $wgPasswordSender
           Product: MediaWiki
           Version: wikimedia-deployment
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: Normal
         Component: Email
        AssignedTo: wikibugs-l@lists.wikimedia.org
        ReportedBy: mediawiki-b...@cboltz.de


includes/DefaultSettings.php has two different defaults for $wgPasswordSender:

a) (line 520 in 1.16):

/**
 * Password reminder email address
 * The address we should use as sender when a user is requesting his password
 * Default to apa...@server_name
 */
$wgPasswordSender   = 'MediaWiki Mail <apache@' . $wgServerName . '>';

Note: this was changed in SVN trunk r76234 to:
$wgPasswordSender = 'apache@' . $serverName;

b) (line 1720 in 1.16):
/** For email notification on page changes */
$wgPasswordSender = $wgEmergencyContact;

This is highly confusing for people who read DefaultSettings.php. Even
http://www.mediawiki.org/wiki/Manual:$wgPasswordSender 
has a section saying so ;-)

Please remove the first setting (it's always overriddenAFAIK) to remove that
confusion.

Bonus points if you move the second/remaining one near the definition of
$wgEmergencyContact so that it's easyer to see what the actual default value 
is ;-)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to