https://bugzilla.wikimedia.org/show_bug.cgi?id=25797

Neil Kandalgaonkar <ne...@wikimedia.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Neil Kandalgaonkar <ne...@wikimedia.org> 2010-11-08 
19:38:49 UTC ---
(In reply to comment #0)
> ...but there are cases when this plugin isn't present, e.g. when the Vector
> extension is not enabled, or when a skin other than Vector is used (although 
> in
> the latter case you have worse things to worry about, see bug 25796). In those
> cases, a JS error is thrown and whatever the suggestions plugin is used for
> doesn't work. Haven't noticed any other bad effects.
> 
> If you want/need to, you can detect the presence of the suggestions plugin 
> with
> if ( 'suggestions' in $j.fn )

We don't have any concept of conditional loading in the primitive resource
loader that I hacked into UploadWizard. Also, it seems that we're being
deployed ahead of ResourceLoader, and some people have asked about using this
with non-WMF wikis.

So, I'm just going to include my own, and if it happens to overwrite the one in
Vector, so be it.

That said we're probably going to have this issue with libs we've hacked up
more at the WMF (like tipsy.js) so I'll have to examine what JS really is in
WMF deployment branch now, and how to avoid having multiple "lines" of
development for these libraries.

Fixed in r76327.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to