https://bugzilla.wikimedia.org/show_bug.cgi?id=21919
--- Comment #28 from Mark A. Hershberger <[email protected]> 2010-11-12 03:22:36 UTC --- Copying this from my notes, will put on CR if it doesn't format here. * From RK: ** Detection for FlaggedRevs presence is fragile and I'm not sure it'll even work any more ** Also, there's an arbitrary, unlimited number of joins against categorylinks, that's a no-go (has potential to make the DB servers sweat) ** It's doing DIY category intersection ** Also, at least one of the two sort modes is likely to be very DB-inefficient. Can't tell for sure cause I can't read the query too well, the code is not very pretty and the query is complex and very dynamic ** Amgine: That's fine; if you can give me a general idea of what the query is gonna look like, I can poke at it (to optimize the above) ** Amgine: What I've given you just now should keep a dev busy for a few hours already. Am of course available for general help, but don't think it'd be useful to do an exhaustive review before those things have been taken care of * From me: ** Echo?!?! REALLY? Don't do it. That and direct output (e.g. closing ?>) should not be done *** To read: http://www.mediawiki.org/wiki/Manual:Special_pages#OutputPage.php ** Don't try to create XML yourself, it doesn't work. Use XMLWriter or DOM to create XML. That way you don't have do xmlEncode(). ** Check http://www.google.com/support/webmasters/bin/answer.py?hl=en&answer=74288 it looks like there are some things in the GNSM format that should be handled. *** should limit number of urls (1000?) *** is there a way to integrate multiple site maps *** document robots.txt? ** Hate the use of params as member variable. *** You should just copy things from wgRequest after checking them. *** Having a member variable named params seems like it is the beginning of confusion. *** Also put wgRequest directly in the foreach, or at the very least closer to the point of use to avoid confusion with the others. *** If you don't intend for the result of $wgRequest to be used, then it shouldn't be in $params at all. ** code indention looks lacking. ** Incorrect use of wfEmptyMsg(??) not sure about this but the function def doesn't match function declaration in GlobalFunctions while examples elsewhere abound. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
