https://bugzilla.wikimedia.org/show_bug.cgi?id=22881

--- Comment #14 from Vitaliy Filippov <vita...@yourcmc.ru> 2010-11-26 23:27:34 
UTC ---
Thanks everybody for remarks :)

(In reply to comment #13)
> I retract that. The timestamp part of the filename is the timestamp when the
> file was moved into the archive, not the timestamp when the file was 
> originally
> uploaded.

Yeah, originally it is. But I personally don't understand the practical sense
of this. The time when the file was moved into the archive is usually equal to
or 1-2 second relative to the time when a new version of the same file was
uploaded. So each version contains timestamp of another, moreover, not always
an accurate one.
I think versions should be independent, and should not form such "linked
lists".

(In reply to comment #12)
> I find it strange that you are doing path generation in recordOldUpload(). Is
> there a specific reason you are not doing that in the caller and pass the
> entire archive name? That would seem a bit more logical to me.

Do you mean concatenating $dstPath instead of passing it as a parameter to
recordOldUpload()? If so, recordOldUpload() uses $dstName as the value of
oi_archive_name DB column, that's the reason.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to