https://bugzilla.wikimedia.org/show_bug.cgi?id=3276

--- Comment #26 from Aryeh Gregor <simetrical+wikib...@gmail.com> 2010-11-28 
19:20:00 UTC ---
It's caused by $wgUseTidy = true;.  It seems like a Tidy bug -- I don't know
what objection it had to your original markup, it validates just fine.  A
minimal test-case exhibiting the problem is

<ol>
    <li>x</li>
</ol>

(That's a tab for indentation, not spaces.)  It inserts a bogus <li> there, so
the number displays as "2.", not "1.".  I worked around it by just removing all
the tabs from your patch, so now Tidy doesn't mess it up so badly.  I should
probably report the bug to Tidy's maintainers, but I don't really have time.

With the patch modified thus, it looks okay, but the display is changed a bit. 
The old markup had a bit less space between the images, and a border around the
whole thing.  It's not a big deal, but were you aiming for pixel-perfect
identical rendering to the previous code here?  If so, I'm not seeing it.

Other than that, it looks fine now.  I'd prefer if you could tweak it to look
just the same as before, but if you don't want to, I'm okay with committing it
as-is, given how long it's taken me to get back to you all this time.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to