Summary: WikiEditor + Liquidthreads: addModules is called once
                    for each comment, increasing page load times
           Product: MediaWiki extensions
           Version: any
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: Normal
         Component: UsabilityInitiative

Created attachment 7883
run addmodules only once

Liquidthreads calls EditPage::getEditToolbar a lot of times (once for each
comment, if I'm not mistaken), each time WikiEditorHooks::addModules runs, and
the result is a huge number of calls to wfMsgReal (over 20000 with a decent
sized lqt talk page), and a drastic increase in page load times. The page will
also contain all the messages multiple times, increasing its size. I've
attached a patch to only run addModules once - I'm not sure this is the correct
way to fix the problem, but addModules shouldn't be adding the same messages
over and over again if it gets called multiple times.

Configure bugmail:
------- You are receiving this mail because: -------
You are on the CC list for the bug.

Wikibugs-l mailing list

Reply via email to