https://bugzilla.wikimedia.org/show_bug.cgi?id=21526

MZMcBride <b...@mzmcbride.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |b...@mzmcbride.com

--- Comment #17 from MZMcBride <b...@mzmcbride.com> 2010-12-08 14:36:39 UTC ---
(In reply to comment #16)
> @Tim Starling
> I wasn’t aware of the performance issues of using create_function, sorry.
> But since the created function is static, it should be trivial to factor it 
> out
> ; I used create_function only because I’m used to use blocks in Ruby. The
> corresponding function should just be:
> 
> function convert_page_to_xml($matches) {
> return '<PAGE value="'.htmlspecialchars($matches[1]).'" />';
> }
> 
> Anyway, since the text layer is computed only once and then cached, I don’t 
> fix
> that’s a big issue.

Tim fixed the issue in r78046. The two revisions were then merged from trunk in
r78047.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to