https://bugzilla.wikimedia.org/show_bug.cgi?id=26743

           Summary: Show preview without javascript results in thread and
                    edit form not showing if it has been bumped since you
                    clicked reply
           Product: MediaWiki extensions
           Version: any
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: Normal
         Component: LiquidThreads
        AssignedTo: agarr...@wikimedia.org
        ReportedBy: nx.devn...@gmail.com
                CC: bhar...@wikimedia.org


Here are the steps to reproduce this bug, bear with me:

1. Disable javascript
2. Open a talk page in two tabs in your browser.
3. Click "reply" on the same comment in both tabs
4. Type something in both tabs
5. In one tab, click save page, wait for the comment to be saved. Make sure you
bump the thread.
6. In the other tab, click show preview.

After this, the thread you were replying to will not be shown (including the
edit form), which means you just lost your comment.

I've tracked down the bug to LqtDiscussionPager::getRows(). The problem is that
this function calls a mysql query that selects all root threads where
thread_sortkey<offset, where offset is the timestamp of the latest comment when
you clicked reply. However, since the thread has since been bumped, the root
comment now has a sortkey larger than this timestamp, so it won't be selected.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to